Allow cloning 50 - Githubissues

jamievicary / globular

Globular

37 stars 9 forks source link

Allow cloning 50 #73

Closed jfarid27 closed 7 years ago

jfarid27 commented 7 years ago

This PR fixes #50:

Adds the ability to clone projects from the workspace view.
Includes Bluebird and Lodash dependency additions.
Adds to the project meta JSON a property called "project_source" to store details about sources of projects, which cloning and sharing both use to store information about where the project came from.

jamievicary commented 7 years ago

Hi Jalil, thanks a lot for your interest in the project, and for your contribution.

It would be nice to discuss your ideas/changes here a bit. Can you explain what these libraries are, and why they're necessary? We're keen to keep down use of libraries as far as possible, within reason.

jfarid27 commented 7 years ago

@jamievicary They were added to give some better support for the changes. These are popular libraries that make coding a bit easier. Lodash adds a great set of utility functions that are nice to use. Bluebird adds a Monadic-like promise library that makes async programming a breeze, so you can get away from callback hell. Both are extremely popular in the node development community.

Also, note the meat of the code is in f46b64c and 7d31ad6 and should be easy to check out.