Added command to get activity!

jamiew / helium-discord-bot

Helium hotspot stats & leaderboards for your Discord server

13 stars 3 forks source link

Added command to get activity! #18

Closed ThaMunsta closed 3 years ago

ThaMunsta commented 3 years ago

This could probably use some refactor - JS is not my best work. There are some bug fixes but also some personal preference changes you can ditch if you don't agree. Thanks for your hard work! This was a great repo to build off of.

jamiew commented 3 years ago

So cool, thanks for the patch! Code looks good on first pass, giving this a spin now

jamiew commented 3 years ago

added some tests
limited results to 20 lines (did you want more than this? it gets noisy!)
added support for "slow burgundy mandrill" in addition to "slow-burgundy-mandrill"
misc let -> const and some other random cleanup while i was in here

Looks great, gonna merge, please send another PR if I missed something or you want to revert that limit=20 change. Could maybe stick that in an ENV var if so?

ThaMunsta commented 3 years ago

Awesome thanks for the cleanup and the shout out! I like the idea of a env config. For example 20 is much cleaner but 18 seems to keep it nicely inside one code block which looks pretty slick. I had something similar to try and replace spaces to dashes but it wasn't working for me so I scrapped it. I realised now I think it's the spaces in the name get split into args. Messing with it in a dev branch and will probably send another PR you're way soon ;) Cheers!