Closed jamiewaese closed 10 years ago
Hmm..
Tooltip -Background is already 97% opaque, either your browser isn't supporting it or it's too hard to notice. -Added 5px padding. -Do you want me to move the entire tool tip up by 20 pixels? Like 20 pixels above the mouse position? The little triangle will not be pointing at the right place then... Note that our green tooltip is also aligned vertically with the DOM element, when popping from the left or right. -I really don't feel the need to draw a dot and connect the tooltip to the dot. The mouse position should be an obvious indicator of where the tooltip is pointing. Also, since the mouse position is not necessarily positioned strategically on the view object, I don't see any point in indicating that position with a dot (it would just be a dot on some random place on the view object). It would also take A LOT more work and extra code maintenance to draw that line than to add the little triangle too (the triangle is pure HTML/CSS, but it might not suffice for the line and circle)! -Actually, the white circles is not my doing. SUBA3 is offline right now (for the second time I've seen). It's been offline for hours. It's also crashing some of the other features on ePlant because there seems to be too many Ajax requests waiting for SUBA3's response. I think the colored circles are important for indicating localization. The stroke color only indicates whether mouse is hovering over it.
GOF label -Adding background to the label is technically undoable in Cytoscape.js. However, they do support outlining the label, which I think is even better. Check it out! If you like it then I'll see if I can duplicate it for other views...
Crashing -Again, due to SUBA3 being offline and Ajax going crazy. In fact, after you try to load a gene, no Ajax request will work because it is freezing on all the SUBA3 requests. I can't even get a response from SUBA3's website! http://suba.plantenergy.uwa.edu.au/
Sticky popup -This is caused by a modification I made yesterday. I tried to prevent Cytoscape from picking up mouse events when mouse is over the popup, but it seems to be backfiring by causing the popup to become glitchy. I recovered it so it should no longer be a problem.
Gene list dialog -Clicking on "Get Data" now removes the gene list dialog.
CYTOSCAPE TOOLTIPS
CYTOSCAPE CIRCLE STYLING It might be a happy accident, but we should keep it. We don't need a lot of colored ink when the stroke around a circle contains the same information. How about this... We fill the circle with color if it's one of our downloaded genes. But for any genes that we haven't downloaded yet, we make the circles white with a colored stroke to show their localization data. This will make it easier to follow a few genes of interest, making it easy to differentiate between the genes your following and others that happen to show up in this view.
While we're waiting for SUBA3 (what is that, by the way) to return our data, default the colors as grey.
When a mouse hovers over the circle, add a thicker grey stroke (like the one you have now when there's a mouse press). When there's a mouse press, temporarily fill the circle with black so people will know their click has been registered.
GOF LABEL Nice discovery with the outlined text labels but they're tough to read like this. Let's go back to the previous non-outlined black letters for all genes except the GOF in the center. For that one, use black text but keep the green outline as you have now. This should set it apart sufficiently. We need to do something similar with the GOF in the Chromosome view as well. If outlining doesn't work in that view, try putting a green rectangle behind the text and omit the underline.
CRASHING Can we tell the program to soldier on if its data sources somehow go offline? Maybe it can put up an alert box indicating something's missing, and then allow you to switch to other views instead of freezing?
STICKY POPUP Fixed!
GENE LIST DIALOG Much better!
I have a few more items to add, but I'll start a new thread so we can mark this as done sooner.
RE Crashing:
I don't think there is a way to avoid it. The program doesn't really crash, it's just that the Ajax queue is filled up with unresponsive requests. Once these requests timeout things become normal again (until Ajax gets plugged again). There is also no way for me to know that the data source is offline, if they are just unresponsive (a 300 second delay does not necessarily mean the source is offline, thus we have timeout limit).
Hey - thanks for adjusting the Cytoscape text. Looks good. For the GOF, lets use the light green we use for the title bar of the unselected annotation popups. The text is hard to read with the middle green.
Looks great with the curved corners.
On 2013-12-13, at 9:58 PM, Hans Yu wrote:
RE Crashing:
I don't think there is a way to avoid it. The program doesn't really crash, it's just that the Ajax queue is filled up with unresponsive requests. Once these requests timeout things become normal again (until Ajax gets plugged again). There is also no way for me to know that the data source is offline, if they are just unresponsive (a 300 second delay does not necessarily mean the source is offline, thus we have timeout limit).
— Reply to this email directly or view it on GitHub.
I changed the color to light green (#E6F9AF), but it seems really hard to notice. Maybe we should use something in between?
I know what you mean. But let's leave it like this for a few days and see how we feel.
On 2013-12-15, at 11:12 PM, Hans Yu wrote:
I changed the color to light green (#E6F9AF), but it seems really hard to notice. Maybe we should use something in between?
— Reply to this email directly or view it on GitHub.
CYTOSCAPE TOOL TIPS Love those Cytoscape tool tips! Can you move them up ~20 pixels? They shouldn't overlap the circle we're looking at. Also add some padding around the text and a 97% opaque background.
Can you draw a line from the middle of the box to mouseX, mouseY, terminating with a little dot? This will connect the popup box to the line.
By the way, I like the white circles with color on the strokes instead. Much cleaner. Nice!
CYTOSCAPE G.O.F. LABEL I can't read the center Gene Of Focus label. The green isn't contrasty enough. How about putting a green rectangle behind black text, sort of like what the title bar in the annotation popups look like? In fact, I was also going to suggest the same thing on the Chromosome View. You still can't easily see which is the GOF, even with the larger font and the underline. There isn't enough contrast between the GOF and the unselected labels. So... the green rectangle background might do it. Think of it like a highlighter pen. It would be nice to have the same convention across views too.
Hey, did you know there's a crash if you're in Cytoscape view and you try to get data for another gene?
CHROMOSOME VIEW ANNOTATION POPUPS Incidentally, I like the 4-way cursor icon when you're moving the annotation popups around the screen. But the move function is a bit sticky, no? Every once in a while it doesn't register the mouseRelease event, and the box follows my mouse around the screen. You have to click to release it again.
CHROMOSOME VIEW GENE LIST BOXES And finally, speaking of sticky boxes... on the Chromosome View, the gene list boxes that appear next to the chromosomes have a habit of sticking around too long. They should be told to go away if the user clicks 'get data' in the annotation popup.