search

jamiewest / signalr_core

ASP.NET Core SignalR Dart Client
https://pub.dev/packages/signalr_core
MIT License
90 stars 58 forks source link

Upgrade http dependency #101

Closed brookman closed 7 months ago

brookman commented 1 year ago

Thank you for providing this package to the Dart/Flutter community. Currently signalr_core depends on an older version of http (^0.13.0). This prevents us from upgrading other packages like realm. Would it be possible to upgrade it to 1.0.0 or 1.1.0? Thanks in advance.

Problem:

Because no versions of signalr_core match >1.1.1 <2.0.0 and signalr_core 1.1.1 depends on http ^0.13.0, signalr_core ^1.1.1 requires http ^0.13.0.
And because realm >=1.3.0 depends on http ^1.0.0, signalr_core ^1.1.1 is incompatible with realm >=1.3.0.
So, because app depends on both realm ^1.3.0 and signalr_core ^1.1.1, version solving failed.
nukeolay commented 1 year ago

@brookman you can use @RCSandberg version that now in pull requests. Just add this to your pubspec.yaml:

  signalr_core:
    git:
      url: https://github.com/RCSandberg/signalr_core.git
      ref: feature/bump-dart-and-package-versions
RCSandberg commented 1 year ago

That PR will hopefully be merged not too far in the future. Until then I'll keep my version up as we require it as well.

The PR in this repo is however depending on another PR to be merged first (https://github.com/jamiewest/sse_channel/pull/2) So when that is in I'll update the one here..

nukeolay commented 1 year ago

@RCSandberg yes, but as your PR depends on your own updated version of sse_channel, we thankfully can use your fork, while PR is not merged. Thanks a lot!

mamaly12 commented 11 months ago

Hi there, Can you give us an update regarding the issue?

jamiewest commented 7 months ago

I updated the package, let me know if there are any issues. Please re-open an issue if the problem persists.