jamiewilson / predawn

Predawn is a dark interface and syntax theme for Sublime Text and Atom.
http://jamiewilson.io/predawn
MIT License
1.8k stars 161 forks source link

Adds support for optionally showing disclosure arrow buttons #132

Closed wolthers closed 7 years ago

wolthers commented 8 years ago

The theme currently doesn't support recursively opening or -closing folders by cmd+shift-clicking the disclosure arrows next to the folders (because they're hidden in the theme). This PR adds an optional setting to show the arrows. It is not to be confused with the predawn_sidebar_arrows option, which essentially just replaces the folder icon with an arrow icon as cmd+shift-clicking these doesn't do anything.

Changes made:

With Show open files disabled image

With Show open files enabled image

jamiewilson commented 8 years ago

Well done! Thanks for the help. I'll try to pull these down today and let you know if I have any questions/feedback before merging.

wolthers commented 8 years ago

You're welcome, thought i'd share it. Let me know if anything is missing!

wolthers commented 8 years ago

@jamiewilson: Any comments thus far?

jamiewilson commented 8 years ago

Unfortunately, no. Haven't had a chance to look at it yet but I should be able to this week. I'll keep you posted.

wolthers commented 8 years ago

Ping :)

jamiewilson commented 8 years ago

Hey man, thanks for the reminder! I'm really sorry, but I've got some other things taking priority over this right now. But it shouldn't be too much longer!

jamiewilson commented 7 years ago

Hey man, I have a small change to this PR: hiding disclosure icons when predawn_sidebar_narrow: true is set. If you want to review here and implement in your PR, I can merge.

https://github.com/jamiewilson/predawn/commit/dbf6a9fb2e5fa9ba10dbb4f76b93933d908e36c1

Thanks for your patience with this. Sorry it took so long.

jamiewilson commented 7 years ago

Hey @wolthers. Wanted to make sure you saw this.