jamigibbs / phantom

A minimalist, responsive portfolio theme for Jekyll with Bootstrap
http://jamigibbs.github.io/phantom/
MIT License
341 stars 410 forks source link

Update to 1.1.0 #9

Closed andywimmer closed 6 years ago

andywimmer commented 6 years ago

Hi @jamigibbs,

I wanted to use this theme and noticed there were a few issues so I went ahead and fixed them 😄

I converted to a Gem-based theme but did not publish to RubyGems as it's your theme. Publish if you approve this PR, if you like.

Aside from that, notable changes are mostly just tidying some things up to make customization easier. Full CHANGELOG entry:

I'll most likely implement basic HTML and CSS minification as well, but I didn't want to stray too far off from your work in this PR. Let me know what you think!

jamigibbs commented 6 years ago

Hi @andywimmer! First I want to apologize deeply letting this PR go for too long. Second I want to thank you for taking the time make these updates and improvements! 🙇‍♀️

The only quirk I'm seeing is that the wide image is overflowing (which could very well have been an issue the theme has always had and I'm just noticing it!).

screen shot 2018-07-24 at 2 50 31 pm

Quickest fix is just to add:

img { width: 100% }

I'm approving your awesome PR and I'll submit a quick follow-up to make that minor update.