Option to take or not into account preexisting topo/bathy

jaminzoda / terra-antiqua

Terra Antiqua is a QGIS plugin for paleogeographic reconstructions.

GNU General Public License v3.0

6 stars 0 forks source link

Option to take or not into account preexisting topo/bathy #191

Closed Diego635 closed 2 years ago

Diego635 commented 3 years ago

OUTDATED COMMENT

The workaround for this comment is in the manual

Compile_TB should take into account preexisting bathymetry when creating a sea. This works fine. However, it shouldn't take into account preexisting topography when a mountain range is created, the algorithm should erase preexisting topo and create new one from scratch. I found a bug here. I had a map where a mountain range had a certain altitude and I tried to create a new range at that area with lower elevation values than the original topography. This didn't work. The new feature created didn't have the elevation values I wanted. I tried to erase all values in that area leaving a blank where I wanted to create the mountain and then it worked. So it seems that the algorithm was taking into account the underlying topography.

jaminzoda commented 3 years ago

This is actually not a bug. It was designed in purpose. The initial topography values are removed only when they are not higher than the calculated one, because if you are drawing a low mountain beside a very high mountain (foothills), you may want this low mountain to gradually shift into the high mountain instead of creating a deep gorge between them. We need to discuss whether we should change it so that it removes all the values before creating a mountain range. In case, if it needs to be changed, I will need to modify the code so that it completely ignores the preexisting topography.

Diego635 commented 3 years ago

The conclusion of our discussion today:

It is best to keep as the default functionality that the tool completely ignores (removes) preexisting topography and bathymetry. This will make it easier for the user to understand that this tool actually creates new topography from scratch.
We will also implement the option to take into account (not remove) preexisting topo/bathy. This will be an option within the Advanced Parameters.
We can also allow the user to customize this. There could be the possibility to define the values to be taken into account and those to be removed while running the tool. E.g.: "keep all negative values that are within the polygon" or "keep all values higher than the maximum height"