search

jammerware / margiebot

MargieBot is a .NET library designed to make building bots for Slack fast, easy, and fun.
MIT License
122 stars 42 forks source link

Pasted images #24

Open ghost opened 7 years ago

ghost commented 7 years ago

Hi Jammerware,

I've been seeing an issue where my bot stops responding. I think I have it tracked to when an image is pasted into Slack from the clipboard. Looks like byte[] buffer = new byte[1024]; in MargieBotWebSocket-> Listen() is insufficient when an image of more than ~250-300K is pasted. I'm assuming the image comes in as part of the message when pasted. Margiebot keels over at line 262 (in this repo) of Bot.cs I've worked round this for now by just upping the buffer to 32768. Is there a less inelegant solution to this ?

Other than that, loving Margiebot, thanks.

Regards, Duncan Macpherson

jammerware commented 7 years ago

Thanks for helping me track this down - I've had the same problem in my implementations, but haven't had time to take a look. I'm honestly not sure if there's a better way to handle it - my knowledge of that level of stuff is a little fuzzy. I'll try to up the buffer when I get a sec, or feel free to submit a PR. Thanks for your help!

On Tue, Mar 14, 2017 at 3:56 AM Duncan notifications@github.com wrote:

Hi Jammerware,

I've been seeing an issue where my bot stops responding. I think I have it tracked to when an image is pasted into Slack from the clipboard. Looks like byte[] buffer = new byte[1024]; in MargieBotWebSocket-> Listen() is insufficient when an image of more than ~250-300K is pasted. I'm assuming the image comes in as part of the message when pasted. Margiebot keels over at line 262 (in this repo) of Bot.cs I've worked round this for now by just upping the buffer to 32768. Is there a less inelegant solution to this ?

Other than that, loving Margiebot, thanks.

Regards, Duncan Macpherson

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jammerware/margiebot/issues/24, or mute the thread https://github.com/notifications/unsubscribe-auth/AASEYjT3kxnlerevGXRUnulK8_Np4kraks5rlkgdgaJpZM4McOza .