jammsen / docker-palworld-dedicated-server

Docker container to easily provision and manage Palworld Dedicated Server
https://hub.docker.com/r/jammsen/palworld-dedicated-server
MIT License
907 stars 157 forks source link

[Feature Request] Add option to block telemetry and prevent server been listed on Community-Server list #108

Closed miaulightouch closed 7 months ago

miaulightouch commented 7 months ago

Have you read the Important information text above

Describe the feature

even we didn't add "EpicApp=PalServer", server would be listed on server list.

My server was unlisted from server list after I blocked these host:

Currently I add these line to my docker compose:

    extra_hosts:
      - api.epicgames.dev:127.0.0.1
      - telemetry.palworldgame.com:127.0.0.1
      - api.palworldgame.com:127.0.0.1

But it would be nice if it's became an option for this docker image.

Additional information

Final checks

masonen commented 7 months ago

Interesting that this works - when i tried this the server crashed regularly with an unhandled exception.

My current assumption was, that this is because they dont handle failed/unanswered calls to the telemetry endpoint correctly.

IF this tuns stable i would see this as a valuable addition

miaulightouch commented 7 months ago

Interesting that this works - when i tried this the server crashed regularly with an unhandled exception.

My current assumption was, that this is because they dont handle failed/unanswered calls to the telemetry endpoint correctly.

IF this tuns stable i would see this as a valuable addition

That's weird, creating a new server or importing a save from an existing server doesn't result in any crashes.

miaulightouch commented 7 months ago

here's my docker-compose.yaml

services:
  palworld-dedicated-server:
    container_name: palworld-dedicated-server
    image: jammsen/palworld-dedicated-server:latest
    restart: always
    ports:
      - 8211:8211/udp
      - 20715:20715/udp
    environment:
      - ALWAYS_UPDATE_ON_START=true
      - SERVER_NAME=test
      - SERVER_DESCRIPTION=
      - ADMIN_PASSWORD=pal
      - SERVER_PASSWORD=
    memswap_limit: -1
    extra_hosts:
      - api.epicgames.dev:127.0.0.1
      - telemetry.palworldgame.com:127.0.0.1
      - api.palworldgame.com:127.0.0.1
masonen commented 7 months ago

Yeah maybe something else was off - blocking telemetry like you works for me - i was before only blocking telemetry but on a DNS resolver level. So it was not resolved which caused an error - with your config it does resolve to localhost which is a difference :) thansk for the config though!

jammsen commented 7 months ago

Hey @miaulightouch i dont see a value in blocking access to something that makes the server work and others able to join.

My goal with this image is to get everyone out there to be able to host their own servers and have fun while gaming ...

Pretty confused on the use-case to be honest

masonen commented 7 months ago

Well. At least blocking telemetry endpoints seems to me a valuable option especially at the current state of the game were privacy might be a concern for users. Especially selfhosters.

But you are right. There are other options to achieve that or just follow the extra hosts approach if privacy is a concern or block it on a dns resolver level in local network etc.

miaulightouch commented 7 months ago

Because the server is listed on this server list, which is from telemetry, some servers have been attacked and destroyed by hackers, even though they are password-protected.

jammsen commented 7 months ago

Feel free to do that in your own firewall or a tool like pyhole.

I will not add this feature to this image, because this image is about hosting Palworld. Its not about advanced networking, thats out of context and you can add it outside of docker just fine. Also the base-image would grow enormous and networking-knowledge would skyrocket for normal users.

I dont think it will add much value to the scope of this image.

Im closing this issue as wont-fix, feel free to reach out again if you need help.

If you like this project, please consider giving this repo and the docker-hub-repo a Star.