search

jammsen / docker-palworld-dedicated-server

Docker container to easily provision and manage Palworld Dedicated Server
https://hub.docker.com/r/jammsen/palworld-dedicated-server
MIT License
907 stars 157 forks source link

[Bug Report] Cant fix small Bug in README.md !? #124

Closed LuthorDevelopment closed 7 months ago

LuthorDevelopment commented 7 months ago

Have you read the Important information text above

Current behavior

Hello, I would have liked to fix a small link error in the README.md but can neither push a new branch nor a fix for the Develop-Branch....

Desired behavior

Is it because of the permissions, or did I just try to push it wrong? Both would be possible :-)

Links to screenshots

No response

To Reproduce

The Hyperlink in the Tutorial-Section linkes to #examples but the link-target has been renamed to #docker-compose-examples

Software setup

Github :-)

Hardware setup

Github :-)

Additional context

No response

thejcpalma commented 7 months ago

Just have to wait for the PR to be approved m8 😅 Jamsmsen is on sabatical to resto so if you need to do changes just do a PR and He'll check when he's available

LuthorDevelopment commented 7 months ago

Just have to wait for the PR to be approved m8 😅 Jamsmsen is on sabatical to resto so if you need to do changes just do a PR and He'll check when he's available

I'm just not sure whether something else is causing it to fail. Normally I create a branch, push it into the repo and create a merge-request. I have never needed a pull request so far :D

git push ERROR: Permission to jammsen/docker-palworld-dedicated-server.git denied to LuthorDevelopment. fatal: Could not read from remote repository.

Please make sure that you have the correct access permissions and the repository exists. To me this looks like a different problem :D Or I'm doing something fundamentally wrong :D

image

jammsen commented 7 months ago

Hey @LuthorDevelopment normally you just fork my repo, change it on your master or develop and create a PR against my master or develop. But im also not a Github Pro sorry 🤣

Do you want to give me the line you having an issue with so i can fix it?

Just have to wait for the PR to be approved m8 😅 Jamsmsen is on sabatical to resto so if you need to do changes just do a PR and He'll check when he's available

@thejcpalma Thanks 😄 also "jammsen" is my prefered way, the "Jammsen" feels just off to me 🤣

LuthorDevelopment commented 7 months ago

Thanks for the info, with an fork and pull-request it works :-)