jammsen / docker-palworld-dedicated-server

Docker container to easily provision and manage Palworld Dedicated Server
https://hub.docker.com/r/jammsen/palworld-dedicated-server
MIT License
911 stars 158 forks source link

improve docker compose example #134

Closed AnzhiZhang closed 8 months ago

AnzhiZhang commented 8 months ago

simplify ports and ensure security by using bridge instead of host to enable network isolation

See-Also: https://docs.docker.com/network/drivers/

I've tested and it works on my server.

jammsen commented 8 months ago

Hey @AnzhiZhang thanks for the contribution.

I prefer the long syntax in readability for new users, to understand if tcp or udp is needed. The default set for ports is "host" anyways, see here: https://docs.docker.com/compose/compose-file/compose-file-v3/#ports

So this PR doesnt change anything mechanically, just readability is less good.