[Bug Report] Multiple backupmanager entries in supercronic cronlist.

SkylerGhostly commented 8 months ago

Have you read the Important information text above

[x] Yes i did

Current behavior

Occasionally, the backupmanager.sh script will be called again even if the cronlist file already contains a job. This causes the backup process to be called multiple times.

Desired behavior

Backup operation should only execute once.

Links to screenshots

https://doe.wtf/6OhtWA https://doe.wtf/0m2q_w

To Reproduce

Steps to reproduce the behavior:

Compose & Start the image.
Use docker compose restart
backupmanager.sh adds another backup entry

Software setup

OS: Ubuntu 22.04.3 LTS
Docker: Docker version 25.0.1, build 29cf629

Hardware setup

vCPU: AMD FX(tm)-8320 Eight-Core Processor, 4013 MHz
RAM: 16 GB DDR3
Disk: 120 GB Sata SSD (Crucial MX200)

Additional context

No response

jammsen commented 8 months ago

This bug should be gone when using docker-compose restart, im not touching now the file but writing it new. Feel free to test this and give me feedback on this.

If you like this project, please consider giving this repo and the docker-hub-repo a Star.

SkylerGhostly commented 8 months ago

Thanks for the quick fix. Much appreciated.

jammsen commented 8 months ago

Thanks for the quick fix. Much appreciated.

No problem, please be aware its only on develop right now.

docker pull jammsen/palworld-dedicated-server:develop

I will merge later to prod/master/latest

jammsen / docker-palworld-dedicated-server