Closed Jadiction closed 7 months ago
Hey @Jadiction - Should the line "content": WEBHOOK_ALL_TITLE,
be removed if the ENV variable is set to empty/nothing?
Also please use the Prefix of titles like i set it up for FR, that helps me to stay organized.
Hey @Jadiction - Should the line
"content": WEBHOOK_ALL_TITLE,
be removed if the ENV variable is set to empty/nothing?
Good question, certain webhooks may require the content to be specified (even if empty). Depending on how you'd like it, I can think of 2 solutions:
I understand this makes it a little specific and would need some extra explaining in the documentation, but I believe it adds customizability.
WEBHOOK_ALL_TITLE
will never be not set, because it goes in the Dockerfile for default-sets and Backwards-Compability.
This makes things more complicated. But when i understand you correctly you would offer:
if "isset" WEBHOOK_ALL_TITLE -> Add line and value if "empty" WEBHOOK_ALL_TITLE -> Remove line
Right? I think talking in pseudo-code is more easy to explain than very comlicated text 🤣
@Jadiction Ping
WEBHOOK_ALL_TITLE
will never be not set, because it goes in the Dockerfile for default-sets and Backwards-Compability. This makes things more complicated. But when i understand you correctly you would offer:
Ah true, after thinking about it, the first solution wouldn't work, my bad. Was thinking differently.
if "isset" WEBHOOK_ALL_TITLE -> Add line and value if "empty" WEBHOOK_ALL_TITLE -> Remove line
Yeah, this would work well. Sorry for the delay.
It doesnt really save space but it works:
Pushing it to develop and to latest later.
@Jadiction Please go ahead and test it and give me feedback.
@Jadiction Please go ahead and test it and give me feedback.
Works good! Thank you!
To me, this looks better rather than repeating the "Status update" when the information in the embed shows everything needed
@Jadiction all good, happy to help!
If you like this project, please consider giving this repo and the Docker-Hub-Repo a Star.
Have you read the Important information text above
Describe the feature
My suggestion is to allow customization/removal of the
"content": "Status update"
in includes/webhook.sh through ENV variables. For Discord webhooks, the message would look better without the content message.Current:
Suggestion: Add an environment variable like "WEBHOOK_ALL_TITLE" (for example) to allow users to customize the message. This way I can set it to nothing and only have the embed. This also helps non-English users who would like to translate it to their server's native language.
Additional information
Final checks