search

jammsen / docker-palworld-dedicated-server

Docker container to easily provision and manage Palworld Dedicated Server
https://hub.docker.com/r/jammsen/palworld-dedicated-server
MIT License
898 stars 151 forks source link

[Bug Report] Player Join/Leave if steam name has spaces breaks message #224

Closed Krojack closed 4 months ago

Krojack commented 4 months ago

Have you read the Important information text above

Current behavior

rcon broadcast stops after the blank space in name.

Desired behavior

To display the entire name and rest of the message

Links to screenshots

No response

To Reproduce

Steps to reproduce the behavior: no real steps, just wait for someone to join/leave that has a space in their steam name.

Software setup

Hardware setup

Additional context

Not 100% sure what script is processing this but I found the following.

I modified the /includes/rcon.sh script for the join/leave functions..

Added this to replace spaces with an underscore PLAYER=$(sed 's/ /_/g' <<< "$1")

Modified rconcli "broadcast ${time}-Player-${PLAYER}-has-left-the-server"

This should work but I haven't seen my friend join to test yet.

Dashboy1998 commented 4 months ago

I made a PR for this. Instead of using sed I used GUN Shell Parameter Expansion

rconcli "broadcast ${time}-Player-${1// /-}-has-joined-the-server"
Krojack commented 4 months ago

Still doesn't seem to be working after I updated this morning. The one with "Lapin" has a blank space in the name.

image

On a side note that I wouldn't worry about, that person is also Alastrim. I'm not sure why it shows 2 times. They show as that name on my Steam friends and their profile. The Lapin part I don't see anywhere. Not sure what Steam is doing there.

jammsen commented 4 months ago

Still doesn't seem to be working after I updated this morning. The one with "Lapin" has a blank space in the name.

image

On a side note that I wouldn't worry about, that person is also Alastrim. I'm not sure why it shows 2 times. They show as that name on my Steam friends and their profile. The Lapin part I don't see anywhere. Not sure what Steam is doing there.

This is only on develop image tag for now, when i release this, i create an annoucement in Discord.

Im working an various edge-cases like special characters and that sort of things right now.

New fix and release, soon'ish