jammsen / docker-palworld-dedicated-server

Docker container to easily provision and manage Palworld Dedicated Server
https://hub.docker.com/r/jammsen/palworld-dedicated-server
MIT License
911 stars 158 forks source link

[Bug Report] Player join/leave doesn't work with players of the same name #228

Closed Dashboy1998 closed 7 months ago

Dashboy1998 commented 7 months ago

Have you read the Important information text above

Current behavior

When multiple players with the same name are playing then join is only logged for the first player to join and left is only logged for the last player to leave.

Desired behavior

Should be announcing when each player joins/leaves.

Links to screenshots

No response

To Reproduce

Steps to reproduce the behavior:

  1. Create a server with no save
  2. Join and create your character
  3. Have someone else join and them use the same name as you
  4. Wait for RCON_PLAYER_DETECTION_CHECK_INTERVAL
  5. Have one player leave and Wait for RCON_PLAYER_DETECTION_CHECK_INTERVAL
  6. Have second player leave

Software setup

N/A

Hardware setup

N/A

Additional context

Being completely honest I can't remember if it's possible or not for two players to have the same name. Pretty sure I tried this and got that result when I was making my PR. However it was a late night so don't remember 100%.

jammsen commented 7 months ago

This should also be fixed, its more steamid oriented now.