Open Jadiction opened 1 week ago
Hey @Jadiction we added that with no toggle for "informing" the players that a lag or a slow-server reaction might be coming in the next 5 seconds. We did that to keep the player informed when stuff happens, when its done and when its over. We would hate it, that someone is in a bossfight and dies because of lags that were not informed and based on backups.
Could you please explain in more detail how a solution for opt-in or opt-out and the idea behind the FR is from your point-of-view please?
Thanks for taking the time and caring!
Hey @Jadiction we added that with no toggle for "informing" the players that a lag or a slow-server reaction might be coming in the next 5 seconds.
Yeah, that's a valid reason to have it and I'm sure some people appreciate it. I would just prefer not to have it and an option to toggle it would be nice. Currently, my backups and saves have arguably unnoticeable server performance. I know this will vary based on how many players, how large the maps are server specs, etc.
I'd prefer to have a cleaner and less spammed chat than to keep informed by a potential small lag spike.
My suggestion is to add an environment variable to make it optional.
if RCON_NOTIFICATIONS
is set to false, it for example, won't use the RCON broadcasts from these functions in rcon.sh:
save_and_shutdown_server broadcast_automatic_restart broadcast_backup_start broadcast_backup_success broadcast_backup_failed
Or if you wanted, you could do 2 variables such as RCON_BACKUP_NOTIFICATIONS
and RCON_SAVE_NOTIFICATIONS
to further the optimization.
Hey @Jadiction
After readind your answer and some thinking about it, i would be open to extend it like this:
We already added BACKUP_ENABLED
to change if you like backups or not. A valid and reasonable extension on to this would something like BACKUP_NOTIFICATIONS_ENABLED
directly after the setting BACKUP_ENABLED
to give context to the user/admin and also to help make more informed decisions.
BUT the value would be on/true by default and for backwards-compability. I really dont like thousands of server to break in an instant, just because the have auto-updates enabled and had not chance to read the patch-notes. Thats a no no.
What the server saves before stoping thing affects, i dont want to change that. I a sense to speak of / in a sense you could say, im open to extend the functions of the "backupmanager.sh but im happy with whats in the servermanager.sh i dont want to touch that. Again it comes down to inform the player of events. Server reboot is setup via cron you can do that every 5m or once a month, that what you can already control whats happening and the "spamming" is in the admins control. But messing with this, also does messing with automation for server-management, im not really happy to change that sorry.
Again im open to hear more feedback, but thats my current offer to extend this.
Have you read the Important information text above
Describe the feature
I am suggesting an environment variable to toggle on/off the RCON backup messages. If not many people are talking, it gets pretty "spammy". For example, this will be repeated each time: I do want rcon enabled for the player messages (join/leave/name change), but my players don't need to know when a world is saving or being backed up. It's unnecessary information/spam for them to see constantly.
Additional information
Final checks