jammsen / docker-palworld-dedicated-server

Docker container to easily provision and manage Palworld Dedicated Server
https://hub.docker.com/r/jammsen/palworld-dedicated-server
MIT License
898 stars 152 forks source link

Add healthcheck to the dockerfile #275

Open Seneschul opened 2 weeks ago

Seneschul commented 2 weeks ago

Have you read the Important information text above

Describe the feature

Docker has the ability to check the health of a dockerfile, and if the dockerfile fails this healthcheck too many times, docker can restart the dockerfile. https://docs.docker.com/reference/dockerfile/#healthcheck I would have suggested using "docker exec palworld-dedicated-server rconcli info" as the basis, but I am given to understand that this suggestion is subpar, as rconcli can have it's own issues, compounding the overall problem. e.g. my suggested command is probably a bad idea.

Another channel member suggested strongly that using ps may be a better solution to the issue of the palworld dockerfile getting hung up, which makes more sense.

Additional information

Final checks

jammsen commented 1 week ago

There are a few ways to solve this, but using an protocol that might not react to requests or might be spammed isnt my favorite because of the high chance of false positives.

I will look into this next weekend, im busy right now.