search

jammsen / docker-palworld-dedicated-server

Docker container to easily provision and manage Palworld Dedicated Server
https://hub.docker.com/r/jammsen/palworld-dedicated-server
MIT License
911 stars 158 forks source link

fixed rcon not being deployed and update readme #33

Closed Plarpoon closed 9 months ago

Plarpoon commented 9 months ago

Hey there,

I’ve been working on some enhancements to the docker-compose setup for the RCON container, which will address the issue mentioned in #31.

Firstly, I noticed the “depends_on” flag was missing, which seemed to be causing some problems with pulling the container. I’ve added this into the configuration.

I’ve also enabled the TTY and stdin_open flags. This should make it easier to attach to the internal console whenever we need to. Plus, I’ve set the containers to not restart automatically when they’re stopped intentionally, which should help with debugging.

On another note, I found out that a Fully Qualified Domain Name (FQDN) works just as well as a public IP. I wasn’t sure about this at first, but after testing it out, it seems to work fine. I’ve updated the public IP category to reflect this.

Thanks for all your hard work on this project. It’s been great to contribute!

jammsen commented 9 months ago

Hey @Plarpoon you posted like 2 texts with roughly the same context i think? I confuses the heck out of me 😕 - Could please make this 1 coherent text?

Thanks for all your hard work on this project. It’s been great to contribute!

No problem, i just want to help everyone with this 😅

Could you please share your thoughts with me on your code changes:

Plarpoon commented 9 months ago

I am dumb @jammsen, forgive me for that, English is my non native language so I often do a complete revision of what I write and then compare to the original to see if it's still understandable.

I am also deep into courses and with 3 hours of sleep on my head. Pretend you have seen nothing 😄

jammsen commented 9 months ago

I am dumb @jammsen, forgive me for that, English is my non native language so I often do a complete revision of what I write and then compare to the original to see if it's still understandable.

English isnt native to me neither, the first and after thing i do actually too, EVEN in my motherlanguage 😅

I am also deep into courses and with 3 hours of sleep on my head. Pretend you have seen nothing 😄

People! Pass on, nothing to see here!

Please when you have time and mind, answer my questions? Pretty please.

Plarpoon commented 9 months ago

I see you changed the restart-policy, why would you want unless-stopped over always when you run a server that should have 99,9% uptime?

I am running on a selfhosted environment (I have a racked server in my basement) and find myself often having to make changes to it. Since this game just recently came out and it's also in early access I am expecting in the near future to have to put it offline for maintenance related tasks and I wouldn't want it to automatically restart each time. It's perfectly understandable if you do not want to change this one, I have literally altered the restart policy exclusively for comfort and thought others would benefit from it. Also with "unless-stopped" you still will have it constantly restarting in case of failure, it's just in case you manually decide to halt it that it stops.

Why remove profiles? Its on purpose there for preventing the RCON container beeing started with the server. Why the name-change? Why depends_on? This wont check if the server is alive, its not a database-server that needs to be alive before the webserver runs.

I actually had a lot of trouble attaching to the RCON from within Portainer (it would just give me a blank screen) and found out that separating the two containers at the moment of deploy and making RCON depending on the server would allow me to just drop-in with the press of a button (instead of manually having to enter a command). And considering the container was now separated I just gave it a generic name.

This made it so now I can manage this project in two click for both maintenance and administration, all without having to even open the terminal. Reason why I want it to be this simple is that my portainer access is public (all with different credentials ofcourse) and I have some non technical adept friends that will have to help me moderating the game.

Perhaps with this image I can give a better idea on how simple it is now to just enter RCON. Screenshot_20240123_174857

Hope everything is now more clear, let me know if something I wrote still doesn't make much sense to you and sorry again for before! My change is obviously up for discussion for anything, I just really like your project and wish to bring further improvement to it!

jammsen commented 9 months ago

I see you changed the restart-policy, why would you want unless-stopped over always when you run a server that should have 99,9% uptime?

I am running on a selfhosted environment (I have a racked server in my basement) and find myself often having to make changes to it. Since this game just recently came out and it's also in early access I am expecting in the near future to have to put it offline for maintenance related tasks and I wouldn't want it to automatically restart each time. It's perfectly understandable if you do not want to change this one, I have literally altered the restart policy exclusively for comfort and thought others would benefit from it.

AHHH thanks makes much more sense now, i indeed would rather not change it, because its likely that it raises more questions then its answers in the long run. Also the docker-compose.yml now is deleted and we have only examples in the readme. Like examples tells me, im free to change that to my needs. I think thats the best way for pros-to-newbies in the long run.

Why remove profiles? Its on purpose there for preventing the RCON container beeing started with the server. Why the name-change? Why depends_on? This wont check if the server is alive, its not a database-server that needs to be alive before the webserver runs.

I actually had a lot of trouble attaching to the RCON from within Portainer (it would just give me a blank screen) and found out that separating the two containers at the moment of deploy and making RCON depending on the server would allow me to just drop-in with the press of a button (instead of manually having to enter a command). And considering the container was now separated I just gave it a generic name.

This made it so now I can manage this project in two click for both maintenance and administration, all without having to even open the terminal. Reason why I want it to be this simple is that my portainer access is public (all with different credentials ofcourse) and I have some non technical adept friends that will have to help me moderating the game.

Hope everything is now more clear, let me know if something I wrote still doesn't make much sense to you and sorry again for before!

Okay now i understand what you mean, yeah there is a custom solution needed when you bring portainer in the mix, because its different from docker-compose on the cli and the newly rising Dockge.

Regarding Dockge (https://github.com/louislam/dockge & https://www.youtube.com/watch?v=HEklvsr7q54 are a must watch imho), im not sure if you are not more happy with Dockge and how its reacting, but maybe you need more node+user management and you should stick to Portainer, evaluate for yourself. I will soon move everything from Portainer to Dockge, because it sometimes gets more in the way as Dockge and i want to monitor my container and logs LIVE in a easy way and Portainer doesnt do this at all.

The solution i offer from the CLI is very easy to use, in Portainer it needs work-arounds yeah, but i would rather not change the "base" in a weird way and make it less functional, just to deliver 5% to Portainer to you? Right now is dont really want to accept the PR because its more edge-cases then "usual" doing if you get my point.

How about a Portainer-Readme with examples or so? Maybe a new issue for that? @Plarpoon

Plarpoon commented 9 months ago

That sounds absolutely reasonable thank you! Also very happy to find another Christian Lempa fan in here, it's mainly thanks to him if I have a homelab, didn't have much time to catch up on his last videos but Dockge looks really cool!

Will write a small Portainer-Readme file and open up a new PR then! Thank you a lot!