search

jammsen / docker-palworld-dedicated-server

Docker container to easily provision and manage Palworld Dedicated Server
https://hub.docker.com/r/jammsen/palworld-dedicated-server
MIT License
907 stars 157 forks source link

Preflight checking RPC & server credentials at runtime #43

Closed mindflay3r closed 7 months ago

mindflay3r commented 7 months ago

Hello pals. Please help keep the users secure by checking that they've changed the default creds.

jammsen commented 7 months ago

Thanks, this is AWESOME! Tiny problem ... sorry 😭 I like the idea of this, the problem is, that we have in the readme to start the server, stop, setup the config and start again, which in-itself is factually wrong. We are working right now on #40 - After that is merged we dont need the start, stop, config, start step again. Its directly ready from the get go and should be always valid. AFTER thats done, im happy to integrate your PR into it the code, are you okay with waiting a little longer? @mindflay3r - Again sorry for the delay.

jammsen commented 7 months ago

Hey @mindflay3r i added the quintessence of your code, i added just a little rewriting, thanks for the contribution.