search

jammsen / docker-palworld-dedicated-server

Docker container to easily provision and manage Palworld Dedicated Server
https://hub.docker.com/r/jammsen/palworld-dedicated-server
MIT License
907 stars 157 forks source link

Add WORLD_OPTION_SETTINGS env variable #44

Closed jtmckay closed 7 months ago

jtmckay commented 7 months ago

Allows configuration of all options for the game via a .env file.

jammsen commented 7 months ago

This looks very interesting and very according to the Docker-Best-Practice way. There is also another PR from @gchai under #40 thats more focussed on very intensive script usage. Hmmm, both are very interesting and ALSO BOTH missing documentation about the "truck-load" of settings we would deliver 🤣 Can we all please stick the heads together and make 1 GREAT solution to this?

jammsen commented 7 months ago

This solution is very Docker-Best-Practice way with using .env files to keep settings and secrets private. But its also fragile and very update heavy on the context of Pocketpair releasing a new config and we have to update this all the time and maybe the gameserver will not start until ALL peole update the config or the image or we fix the bug, because of missing params or failed validation or 100 other things we didnt thing about. The worst thing here can happen is that hundreds of server restart, get new server files and NONE is starting, which would be really bad and people surely would be sad or pissed off 🤣 and increase drastically traffic to the "issue-section" 🤣

The other solution is very scripting heavy and extends quite far the servermanager, but respects 100% the Default-Config that comes with the gameserver over SteamCMD no matter what happens. The worst thing here can happen is that the gameserver just starts and 1 config-param was not set/applied and its back to default-value then, BUT its always running. Which has a certain value for a "customer-perspective".

Any thoughts or problems i missed or problems with my analysis?

jammsen commented 7 months ago

Seems like the discussion and a draft on the readme started over at #40 🤷 @jtmckay please help out too over there.

jtmckay commented 7 months ago

What I like about this solution, is that I don't have to re-build the docker image every time I need to change/add a setting. I would assume that Pocketpair would not make a breaking change where a previous config no longer functions, but maybe I'm giving them too much credit.

I actually didn't see the alternative solution until I already submitted this PR. I just thought I'd share back what I found useful, incase it's useful back here, since this was useful for me, and I appreciated it @jammsen. Happy to go either way.

jammsen commented 7 months ago

What I like about this solution, is that I don't have to re-build the docker image every time I need to change/add a setting. I would assume that Pocketpair would not make a breaking change where a previous config no longer functions, but maybe I'm giving them too much credit.

I actually didn't see the alternative solution until I already submitted this PR. I just thought I'd share back what I found useful, incase it's useful back here, since this was useful for me, and I appreciated it @jammsen. Happy to go either way.

Thanks for your help and honesty, i value this much!

With #40 as solution we can add .env too, i asked that question at the end of my latest comment on #40 . There should be no need to rebuild the image the way i want this to be resolved and an .env would be also in question for my solution.

jammsen commented 7 months ago

Thanks for the contribution, closing this in favor of #40 which is already commited by me