search

jammutkarsh / pms

Project Management S̶y̶s̶t̶e̶m̶ Sucks - A CLI tool to manage all your project.
MIT License
6 stars 1 forks source link

feat: add pathFinder function to clean paths #13

Closed sidkhuntia closed 10 months ago

sidkhuntia commented 11 months ago

Fixes #7 This commit introduces a new function, pathFinder, which takes a path as input and returns a cleaned version of the path. This function uses the filepath.Clean function from the path/filepath package in Go, which simplifies any .. or . references in the path. out

sidkhuntia commented 11 months ago

@JammUtkarsh what do you think where should i use the pathFinder func ?

jammutkarsh commented 10 months ago

Okay, I didn't knew that a function like filepath.Clean(path). So we don't need to create a function and tests around it, since it comes from std lib and it would have been already tested.

You just need to change one like, which I marked and that will all be good.

sidkhuntia commented 10 months ago

Do I need to squash the commits also?

jammutkarsh commented 10 months ago

Yes, 1 commit for 1 minor fix or feature. The reason I do this(and make you do this) is to have a cleaner(and presentable) commit history.

I read this and started making atomic commits in locally. If the contribution guidelines requires me to make a single commit for a feature, then I squash them.

sidkhuntia commented 10 months ago

I will give it a read, thanks for sharing