search

jamoma / JamomaCore

Jamoma Frameworks for Audio and Control Structure
Other
36 stars 14 forks source link

TTSampleMatrix remove use of unsigned variables in functions #118

Closed nwolek closed 11 years ago

nwolek commented 11 years ago

The unsigned variables used in TTSampleMatrix are inconsistent with other functions. https://github.com/jamoma/JamomaCore/blob/master/DSP/library/includes/TTSampleMatrix.h

TTErr peek(const TTUInt64 index, const TTUInt16 channel, TTSampleValue& value); TTErr peeki(const TTFloat64 index, const TTUInt16 channel, TTSampleValue& value); TTErr poke(const TTUInt64 index, const TTUInt16 channel, const TTSampleValue value);

They should use the TTRowID & TTColumnID typedefs defined in TTMatrix.h for consistency. https://github.com/jamoma/JamomaCore/blob/master/Foundation/library/includes/TTMatrix.h

OR BETTER perhaps even define audio specific typedefs? like... TTChannelIndex & TTSampleIndex

nwolek commented 11 years ago

this was fixed during work on the SoundfileLib.