search

jamoma / JamomaCore

Jamoma Frameworks for Audio and Control Structure
Other
37 stars 14 forks source link

Should we create additional Jamoma Error Codes? #121

Closed nwolek closed 11 years ago

nwolek commented 11 years ago

kTTErrGeneric gets overused in my opinion. It would be nice to have a few more useful, specific, descriptive error codes. One I can specifically think of in my current work would be something like: kTTErrInstantiateFailed for when a Jamoma object failed to load.

Are there others we would like to see? Creating a list first would help give the implementation some direction.

Is it just me that sees this as an issue? If not, I am willing to gather suggestions and try to enhance this part of the Core.

nwolek commented 11 years ago

Here's a link to this enumeration in the source: https://github.com/jamoma/JamomaCore/blob/master/Foundation/library/includes/TTBase.h#L311

tap commented 11 years ago

+1

Nilson commented 11 years ago

+1

nwolek commented 11 years ago

Here's two that I see a need for in my current work:

kTTErrInstantiateFailed - The Jamoma object that you tried to instantiate was unsuccessful kTTErrInvalidFilepath - Something was wrong with the filepath you submitted

Are there other immediate suggestions?

tap commented 11 years ago

I think you should just go ahead and add them and we can always add more later as desired.

lossius commented 11 years ago

I just consulted my shoes and they said: "Just do it".

I believe the key here is that new error codes gets properly doxygen documented, and also that we find a way of structuring/grouping them that makes it easier to see what error codes are there and how they might be related.

:-)

nwolek commented 11 years ago

i guess closing from a commit comment only works on master branch. going manual.