search

jamoma / JamomaCore

Jamoma Frameworks for Audio and Control Structure
Other
36 stars 14 forks source link

remake TTSoundfilePlayer as a subclass of TTSoundfile #159

Open nwolek opened 11 years ago

nwolek commented 11 years ago

There is no reason not to have this now be a subclass much like TTSoundfileLoader and make things DRY. All the interaction with the sound file happens in TTSoundfile, so that becomes the only place we interact with third party libraries.

Current version: https://github.com/jamoma/JamomaCore/blob/dev/DSP/extensions/SoundfileLib/includes/TTSoundfilePlayer.h https://github.com/jamoma/JamomaCore/blob/dev/DSP/extensions/SoundfileLib/sources/TTSoundfilePlayer.cpp

Model for revision: https://github.com/jamoma/JamomaCore/blob/dev/DSP/extensions/SoundfileLib/includes/TTSoundfileLoader.h https://github.com/jamoma/JamomaCore/blob/dev/DSP/extensions/SoundfileLib/sources/TTSoundfileLoader.cpp

tap commented 11 years ago

+1

nwolek commented 9 years ago

TTSoundfileLib is being quarantined for 1.0 release. If this issue is addressed, it will be done for 1.1 or in jamoma2.