search

jamoma / JamomaCore

Jamoma Frameworks for Audio and Control Structure
Other
36 stars 14 forks source link

DSP not compiling - TTSoundfileLoader in SampleMatrix #163

Closed caseybasichis closed 10 years ago

caseybasichis commented 11 years ago

DSP isn't compiling from a fresh checkout as TTSampleMatrix.cpp is referencing TTSoundfileLoader.h which should be it's own extension

nwolek commented 11 years ago

@caseybasichis - Can you give me a few more details? I thought I made this link light enough to avoid compiler issues.

caseybasichis commented 11 years ago

@nwolek yes indeed.

I'm not sure if it's an issue with the code or just the search paths in the xcode projects. It definitely isn't compiling fresh without adjustments.

The TTSampleMatrix.cpp has an #include for TTSoundfileLoader which exists in an extension module and not the core. My understanding is that having dependencies outside of a module is a bad thing but perhaps you guys have a plan in that regard.

nwolek commented 11 years ago

OK, try commenting out the include here: https://github.com/jamoma/JamomaCore/blob/dev/DSP/library/source/TTSampleMatrix.cpp#L18

It should still work. This include statement is likely a residual from before I was using the TTAudioObject syntax here: https://github.com/jamoma/JamomaCore/blob/dev/DSP/library/source/TTSampleMatrix.cpp#L338

Basically I am using that syntax to create an object from the extension, but the Jamoma doesn't need to know about the extension before then. Then it just sends a message to make the load happen.

Don't think I have time to test myself today. We can leave this issue open until I can confirm.

nwolek commented 10 years ago

confirmed that this include is not necessary to compile DSP