jamoma / JamomaCore

Jamoma Frameworks for Audio and Control Structure
Other
36 stars 14 forks source link

Are we ready to merge 'dictionary-rewrite' into 'dev'? #182

Closed nwolek closed 10 years ago

nwolek commented 10 years ago

@theod

Just tested and it all builds except the usual: AudioUnit & j.plug.parameter#

tap commented 10 years ago

There shouldn't be audio unit failures anymore -- I moved that extension to an "inactive" folder last week. So if you see a failure with that then something is actually wrong now.

best, | : ||

On Wed, Nov 20, 2013 at 8:16 AM, nwolek notifications@github.com wrote:

@theod https://github.com/theod

Just tested and it all builds except the usual: AudioUnit & j.plug.parameter#

— Reply to this email directly or view it on GitHubhttps://github.com/jamoma/JamomaCore/issues/182 .

nwolek commented 10 years ago

It seems that even though the folder is moved for git, the local file system lets the folder hang around. You have to manually delete using the OS, then the error goes away. This is because the Ruby script is just looking in every extension folder and then finds a makefile because these are not under version control.

Deleting my local folder. Others should do the same to resolve.

nwolek commented 10 years ago

@theod and I just discussed via Skype and Hangout. Our analysis shows that the work in 'dictionary-rewrite' is already part of the 'dev' branch. This is likely due to branch that happened between commits 28e7d2b & 83a2824

I am working on some git clean up, but we should consider this work merged to 'dev'!