TTFreeHandFunction::test fails

[nwolek]

commented out temporarily to implement build & test

[nwolek]

@lossius - You are listed as the original author of this function. Can you look at the output to see what the issue might be here? There are 126 bad samples according to the test comparison. Similar to issue #183

[nwolek]

Looks like @theod wrote the original function, but @lossius wrote the test. I would appreciate one or both of you looking at this, because I don't see an obvious pattern to these results:

TESTING freehand BAD SAMPLE @ n=1 ( value=0.00787402 expected=0.00128882 ) BAD SAMPLE @ n=2 ( value=0.015748 expected=0.00265553 ) BAD SAMPLE @ n=3 ( value=0.023622 expected=0.00410462 ) BAD SAMPLE @ n=4 ( value=0.0314961 expected=0.00564078 ) BAD SAMPLE @ n=5 ( value=0.0393701 expected=0.00726895 ) BAD SAMPLE @ n=6 ( value=0.0472441 expected=0.00899431 ) BAD SAMPLE @ n=7 ( value=0.0551181 expected=0.0108223 ) BAD SAMPLE @ n=8 ( value=0.0629921 expected=0.0127586 ) BAD SAMPLE @ n=9 ( value=0.0708661 expected=0.0148091 ) BAD SAMPLE @ n=10 ( value=0.0787402 expected=0.0169802 ) BAD SAMPLE @ n=11 ( value=0.0866142 expected=0.0192781 ) BAD SAMPLE @ n=12 ( value=0.0944882 expected=0.0217099 ) BAD SAMPLE @ n=13 ( value=0.102362 expected=0.0242824 ) BAD SAMPLE @ n=14 ( value=0.110236 expected=0.027003 ) BAD SAMPLE @ n=15 ( value=0.11811 expected=0.0298793 ) BAD SAMPLE @ n=16 ( value=0.125984 expected=0.0329192 ) BAD SAMPLE @ n=17 ( value=0.133858 expected=0.0361309 ) BAD SAMPLE @ n=18 ( value=0.141732 expected=0.0395228 ) BAD SAMPLE @ n=19 ( value=0.149606 expected=0.0431034 ) BAD SAMPLE @ n=20 ( value=0.15748 expected=0.0468819 ) BAD SAMPLE @ n=21 ( value=0.165354 expected=0.0508673 ) BAD SAMPLE @ n=22 ( value=0.173228 expected=0.055069 ) BAD SAMPLE @ n=23 ( value=0.181102 expected=0.0594964 ) BAD SAMPLE @ n=24 ( value=0.188976 expected=0.0641595 ) BAD SAMPLE @ n=25 ( value=0.19685 expected=0.0690678 ) BAD SAMPLE @ n=26 ( value=0.204724 expected=0.0742315 ) BAD SAMPLE @ n=27 ( value=0.212598 expected=0.0796605 ) BAD SAMPLE @ n=28 ( value=0.220472 expected=0.0853647 ) BAD SAMPLE @ n=29 ( value=0.228346 expected=0.0913541 ) BAD SAMPLE @ n=30 ( value=0.23622 expected=0.0976385 ) BAD SAMPLE @ n=31 ( value=0.244094 expected=0.104228 ) BAD SAMPLE @ n=32 ( value=0.251969 expected=0.111131 ) BAD SAMPLE @ n=33 ( value=0.259843 expected=0.118357 ) BAD SAMPLE @ n=34 ( value=0.267717 expected=0.125915 ) BAD SAMPLE @ n=35 ( value=0.275591 expected=0.133814 ) BAD SAMPLE @ n=36 ( value=0.283465 expected=0.14206 ) BAD SAMPLE @ n=37 ( value=0.291339 expected=0.15066 ) BAD SAMPLE @ n=38 ( value=0.299213 expected=0.159622 ) BAD SAMPLE @ n=39 ( value=0.307087 expected=0.16895 ) BAD SAMPLE @ n=40 ( value=0.314961 expected=0.178648 ) BAD SAMPLE @ n=41 ( value=0.322835 expected=0.18872 ) BAD SAMPLE @ n=42 ( value=0.330709 expected=0.199167 ) BAD SAMPLE @ n=43 ( value=0.338583 expected=0.209991 ) BAD SAMPLE @ n=44 ( value=0.346457 expected=0.221191 ) BAD SAMPLE @ n=45 ( value=0.354331 expected=0.232764 ) BAD SAMPLE @ n=46 ( value=0.362205 expected=0.244707 ) BAD SAMPLE @ n=47 ( value=0.370079 expected=0.257014 ) BAD SAMPLE @ n=48 ( value=0.377953 expected=0.269678 ) BAD SAMPLE @ n=49 ( value=0.385827 expected=0.282689 ) BAD SAMPLE @ n=50 ( value=0.393701 expected=0.296038 ) BAD SAMPLE @ n=51 ( value=0.401575 expected=0.30971 ) BAD SAMPLE @ n=52 ( value=0.409449 expected=0.323693 ) BAD SAMPLE @ n=53 ( value=0.417323 expected=0.337968 ) BAD SAMPLE @ n=54 ( value=0.425197 expected=0.352518 ) BAD SAMPLE @ n=55 ( value=0.433071 expected=0.367322 ) BAD SAMPLE @ n=56 ( value=0.440945 expected=0.38236 ) BAD SAMPLE @ n=57 ( value=0.448819 expected=0.397607 ) BAD SAMPLE @ n=58 ( value=0.456693 expected=0.413039 ) BAD SAMPLE @ n=59 ( value=0.464567 expected=0.428629 ) BAD SAMPLE @ n=60 ( value=0.472441 expected=0.444351 ) BAD SAMPLE @ n=61 ( value=0.480315 expected=0.460177 ) BAD SAMPLE @ n=62 ( value=0.488189 expected=0.476076 ) BAD SAMPLE @ n=63 ( value=0.496063 expected=0.49202 ) BAD SAMPLE @ n=64 ( value=0.503937 expected=0.50798 ) BAD SAMPLE @ n=65 ( value=0.511811 expected=0.523924 ) BAD SAMPLE @ n=66 ( value=0.519685 expected=0.539823 ) BAD SAMPLE @ n=67 ( value=0.527559 expected=0.555649 ) BAD SAMPLE @ n=68 ( value=0.535433 expected=0.571371 ) BAD SAMPLE @ n=69 ( value=0.543307 expected=0.586961 ) BAD SAMPLE @ n=70 ( value=0.551181 expected=0.602393 ) BAD SAMPLE @ n=71 ( value=0.559055 expected=0.61764 ) BAD SAMPLE @ n=72 ( value=0.566929 expected=0.632678 ) BAD SAMPLE @ n=73 ( value=0.574803 expected=0.647482 ) BAD SAMPLE @ n=74 ( value=0.582677 expected=0.662032 ) BAD SAMPLE @ n=75 ( value=0.590551 expected=0.676307 ) BAD SAMPLE @ n=76 ( value=0.598425 expected=0.69029 ) BAD SAMPLE @ n=77 ( value=0.606299 expected=0.703962 ) BAD SAMPLE @ n=78 ( value=0.614173 expected=0.717311 ) BAD SAMPLE @ n=79 ( value=0.622047 expected=0.730322 ) BAD SAMPLE @ n=80 ( value=0.629921 expected=0.742986 ) BAD SAMPLE @ n=81 ( value=0.637795 expected=0.755293 ) BAD SAMPLE @ n=82 ( value=0.645669 expected=0.767236 ) BAD SAMPLE @ n=83 ( value=0.653543 expected=0.778809 ) BAD SAMPLE @ n=84 ( value=0.661417 expected=0.790009 ) BAD SAMPLE @ n=85 ( value=0.669291 expected=0.800833 ) BAD SAMPLE @ n=86 ( value=0.677165 expected=0.81128 ) BAD SAMPLE @ n=87 ( value=0.685039 expected=0.821352 ) BAD SAMPLE @ n=88 ( value=0.692913 expected=0.83105 ) BAD SAMPLE @ n=89 ( value=0.700787 expected=0.840378 ) BAD SAMPLE @ n=90 ( value=0.708661 expected=0.84934 ) BAD SAMPLE @ n=91 ( value=0.716535 expected=0.85794 ) BAD SAMPLE @ n=92 ( value=0.724409 expected=0.866186 ) BAD SAMPLE @ n=93 ( value=0.732283 expected=0.874085 ) BAD SAMPLE @ n=94 ( value=0.740157 expected=0.881643 ) BAD SAMPLE @ n=95 ( value=0.748031 expected=0.888869 ) BAD SAMPLE @ n=96 ( value=0.755906 expected=0.895772 ) BAD SAMPLE @ n=97 ( value=0.76378 expected=0.902361 ) BAD SAMPLE @ n=98 ( value=0.771654 expected=0.908646 ) BAD SAMPLE @ n=99 ( value=0.779528 expected=0.914635 ) BAD SAMPLE @ n=100 ( value=0.787402 expected=0.92034 ) BAD SAMPLE @ n=101 ( value=0.795276 expected=0.925768 ) BAD SAMPLE @ n=102 ( value=0.80315 expected=0.930932 ) BAD SAMPLE @ n=103 ( value=0.811024 expected=0.935841 ) BAD SAMPLE @ n=104 ( value=0.818898 expected=0.940504 ) BAD SAMPLE @ n=105 ( value=0.826772 expected=0.944931 ) BAD SAMPLE @ n=106 ( value=0.834646 expected=0.949133 ) BAD SAMPLE @ n=107 ( value=0.84252 expected=0.953118 ) BAD SAMPLE @ n=108 ( value=0.850394 expected=0.956897 ) BAD SAMPLE @ n=109 ( value=0.858268 expected=0.960477 ) BAD SAMPLE @ n=110 ( value=0.866142 expected=0.963869 ) BAD SAMPLE @ n=111 ( value=0.874016 expected=0.967081 ) BAD SAMPLE @ n=112 ( value=0.88189 expected=0.970121 ) BAD SAMPLE @ n=113 ( value=0.889764 expected=0.972997 ) BAD SAMPLE @ n=114 ( value=0.897638 expected=0.975718 ) BAD SAMPLE @ n=115 ( value=0.905512 expected=0.97829 ) BAD SAMPLE @ n=116 ( value=0.913386 expected=0.980722 ) BAD SAMPLE @ n=117 ( value=0.92126 expected=0.98302 ) BAD SAMPLE @ n=118 ( value=0.929134 expected=0.985191 ) BAD SAMPLE @ n=119 ( value=0.937008 expected=0.987241 ) BAD SAMPLE @ n=120 ( value=0.944882 expected=0.989178 ) BAD SAMPLE @ n=121 ( value=0.952756 expected=0.991006 ) BAD SAMPLE @ n=122 ( value=0.96063 expected=0.992731 ) BAD SAMPLE @ n=123 ( value=0.968504 expected=0.994359 ) BAD SAMPLE @ n=124 ( value=0.976378 expected=0.995895 ) BAD SAMPLE @ n=125 ( value=0.984252 expected=0.997344 ) BAD SAMPLE @ n=126 ( value=0.992126 expected=0.998711 ) badSampleCount is 126

[lossius]

Hi Nathan,

Once we're past the first batch of Christmas craze, we could schedule a skype to look into this, and I could get properly updated on what you need me to do. How would a skype sometime December 27 work for you?

Cheers, Trond

[nwolek]

Hei Trond! Sounds like a good plan. We'll talk then. --Nathan

[lossius]

I'm assigning this to Theo, as I don't really understand what this one is doing. @theod : It would be great if you could add quite a bit of comments to it explaining in more details what this function does, and the reasoning behind it. As it is now, i'm not able to understand what kind of signals we should expect in unit tests.

[theod]

I've filled the details field and made a simple test to check if the default behavior is the linear one.