jamoma / JamomaCore

Jamoma Frameworks for Audio and Control Structure
Other
36 stars 14 forks source link

Dependencies for build & test not working in AudioGraph #187

Closed nwolek closed 10 years ago

nwolek commented 10 years ago

see commit 43118d0

nwolek commented 10 years ago

Other libraries are dependent on themselves & Foundation. This one is dependent on AudioGraph, Graph & Foundation. See the YAML file here: https://github.com/jamoma/JamomaCore/blob/master/AudioGraph/library/JamomaAudioGraph.yml

The if statements I built into the jamomalib.rb script only include the "self" & Foundation as dependencies: https://github.com/jamoma/JamomaCore/blob/dev/Shared/jamomalib.rb#L1718

Since these are hard coded into the script, when the dependencies change it will break the testing until the script gets updated too. I am thinking a better way to handle this would be to use the YAML information to reconfigure the dependencies for testing. That way when YAML is updated, it will generate a new makefile to properly test during build.

tap commented 10 years ago

Agree! Great idea!

Other libraries are dependent on themselves & Foundation. This one is dependent on AudioGraph, Graph & Foundation. See the YAML file here:

https://github.com/jamoma/JamomaCore/blob/master/AudioGraph/library/JamomaAudioGraph.yml

The if statements I built into the jamomalib.rb script only include the "self" & Foundation as dependencies: https://github.com/jamoma/JamomaCore/blob/dev/Shared/jamomalib.rb#L1718

Since these are hard coded into the script, when the dependencies change it will break the testing until the script gets updated too. I am thinking a better way to handle this would be to use the YAML information to reconfigure the dependencies for testing. That way when YAML is updated, it will generate a new makefile to properly test during build.

— Reply to this email directly or view it on GitHubhttps://github.com/jamoma/JamomaCore/issues/187#issuecomment-29391740 .