2 different TTRamps in different submodules

jamoma / JamomaCore

Jamoma Frameworks for Audio and Control Structure

Other

36 stars 14 forks source link

2 different TTRamps in different submodules #195

Open nwolek opened 10 years ago

nwolek commented 10 years ago

Are @tap and @theod aware that there are 2 TTRamps? Discovered this while working on #185

here in DSP/GeneratorLib: https://github.com/jamoma/JamomaCore/blob/master/DSP/extensions/GeneratorLib/includes/TTRamp.h

here in Modular/PeerObject: https://github.com/jamoma/JamomaCore/blob/master/Modular/library/PeerObject/TTRamp.h

I have a vague memory of this being mentioned in Albi June 2013, but I don't see it noted in the issues list. Not sure what (if anythin) needs to be done about it.

tap commented 10 years ago

That is ambiguous and confusing, thanks for noticing it. The following could be argued:

each library could have name prefixes more specific than "TT" -- e.g. TTDSP, TTAG, TTMOD, etc.
the dsp TTRamp class should be renamed because maybe there is a better name? or a more mathematical name? or???
the modular TTRamp class should be renamed because the one in DSP is older and existed first

FWIW, I do not like the first item.

best, | : ||

nwolek commented 10 years ago

I agree first item is ugly. I could justify for 2 or 3.

tap commented 10 years ago

We have agreed to rename the one in Modular should be renamed from TTRamp to TTEase because it implements Easing Functions.