search

jamoma / JamomaCore

Jamoma Frameworks for Audio and Control Structure
Other
36 stars 14 forks source link

Refactor out 1 deprecation warnings in TTDictionaryAppend #252

Closed nwolek closed 10 years ago

nwolek commented 10 years ago

/Volumes/Storage/xcode_projects/Jamoma/Core/Graph/extensions/DictionaryLib/source/TTDictionaryAppend.cpp /Volumes/Storage/xcode_projects/Jamoma/Core/Graph/extensions/DictionaryLib/source/TTDictionaryAppend.cpp:46:8: 'get' is deprecated

nwolek commented 10 years ago

wondering if I can do some object name sniffing to fix this one like I did here: https://github.com/jamoma/JamomaCore/blob/master/DSP/extensions/SoundfileLib/sources/TTSoundfileLoader.cpp#L73

my attempt to do this compiles, but I am afraid to commit because there is no clear test

tap commented 10 years ago

@nwolek -- I don't understand your comment. How does object name sniffing relate to deprecation warnings?

nwolek commented 10 years ago

deprecated call is still there on commit 999924f

https://github.com/jamoma/JamomaCore/blob/merge/api_and_api-cleanup/Graph/extensions/DictionaryLib/source/TTDictionaryAppend.cpp

nwolek commented 10 years ago

Side conversation about "object name sniffing" between @tap & myself continued in person during Bergen workshop. It actually evolved into thinking about safer ways to pass TTObject via TTValue. I thought I remembered further conversation about this since Bergen, but cannot find any emails.

But this is certainly a redesign for after 0.6