jamoma / JamomaCore

Jamoma Frameworks for Audio and Control Structure
Other
36 stars 14 forks source link

Sort out relationships among TTMatrixBase & friends #296

Closed nwolek closed 8 years ago

nwolek commented 10 years ago

TTMatrixBase > TTMatrix (should have a base)? > TTSampleMatrix TTMatrixBase > TTMatrix

nwolek commented 10 years ago

Seems like the TTMatrixObject may be redundant now: https://github.com/jamoma/JamomaCore/blob/merge/api_and_api-cleanup/Foundation/library/includes/TTMatrixObject.h

https://github.com/jamoma/JamomaCore/blob/merge/api_and_api-cleanup/Foundation/library/source/TTMatrixObject.cpp

@tap - did you have any intentions for this beside what TTMatrixBase & TTMatrix do?

tap commented 10 years ago

I think you are right. Please axe it TTMatrixObject if it is unused.

nwolek commented 10 years ago

c84aead236224ad9614c6118132495cb

nwolek commented 10 years ago

Whiteboard sketch feels like too many layers of reference counting. Not sure I like TTSampleMatrix and TTAudioBuffer both doing the reference counting. Would it be so bad if the features of TTBuffer were collapsed into the TTSampleMatrix?

(mostly asking myself, but others are free to chime in)

nwolek commented 10 years ago

Then again, having both TTSampleMatrix and TTAudioBuffer provides a way to choose whether you use the librarian features (and associated overhead). OK, convincing myself.

Now question is name: TTBuffer or TTAudioBuffer? The second is more descriptive.

tap commented 10 years ago

+1 for TTAudioBuffer

best, Tim

On Fri, May 16, 2014 at 8:09 PM, nwolek notifications@github.com wrote:

Then again, having both TTSampleMatrix and TTAudioBuffer provides a way to choose whether you use the librarian features (and associated overhead). OK, convincing myself.

Now question is name: TTBuffer or TTAudioBuffer? The second is more descriptive.

— Reply to this email directly or view it on GitHubhttps://github.com/jamoma/JamomaCore/issues/296#issuecomment-43393439 .

nwolek commented 10 years ago

There are a lot of public methods in the TTMatrixBase object, which is making this a pain. Sorry, just needed to vent.

nwolek commented 8 years ago

Discussed at Florida workshop. We have a new strategy in jamoma2 that will make this obsolete.