search

jamoma / JamomaCore

Jamoma Frameworks for Audio and Control Structure
Other
36 stars 14 forks source link

Comparison of 2 TTSymbol inside TT_ASSERT is casted in TTSymbol #321

Open theod opened 9 years ago

theod commented 9 years ago

here the line :

TT_ASSERT("TTTimeCondition::EventStatusChanged : status effectively changed", newStatus != oldStatus);

I can't give more detail for now but I'll try to give a test.

tap commented 9 years ago

Assigning back to you @theod for clarification, as I don't understand what this means.

theod commented 9 years ago

Here a simple test to make the test failed (I've try by adding theses lines into an existing test) : 

TTSymbol a("a");
TTSymbol b("b");
TT_ASSERT("TT_ASSERT do strange stuff with the following expression", a != b);

It should failed to build.

theod commented 9 years ago

I mean the test executable should not pass due to crash when going into the TT_ASSERT.

tap commented 9 years ago

I think I do not understand. "a" is not equal to "b", so therefore "a != b" is true and the assertion passes (as it should). So maybe I need some more info or a little test program or something?

Tim

On Mon, Dec 22, 2014 at 10:48 AM, theod notifications@github.com wrote:

I mean the test executable should not pass due to crash when going into the TT_ASSERT.

— Reply to this email directly or view it on GitHub https://github.com/jamoma/JamomaCore/issues/321#issuecomment-67859740.

theod commented 9 years ago

I've created a fix/321 branch to allow you to test it. as you will see when you'll build Core, Foundation library fails now for a very strange reason (as far I remember the boolean result was casted into a symbol or something like that …).