jamoma / JamomaCore

Jamoma Frameworks for Audio and Control Structure
Other
36 stars 14 forks source link

TTFoundationInit design #336

Open tap opened 9 years ago

tap commented 9 years ago

From the #333 code review:

void TTFoundationInit(const char* pathToBinaries, bool loadFromOtherPaths)

Without reading the source code, I find this bool "loadFromOtherPaths" to be a really confusing (or at least not self-documenting) name. But looking at this raises bigger questions...

In some of the new code we are using a vector of strings. It is very temping to say that TTFoundationInit() should be rewritten to accept such a vector, e.g. TTFoundationInit(TTStringVector pathsToExtensions).

I'm assigning to Antoine for now as he may have the freshest perspective and I'd like his feedback, but anyone may jump in here or comment.