jamoma / JamomaCore

Jamoma Frameworks for Audio and Control Structure
Other
37 stars 14 forks source link

TTRegex: Switch to std::regex and eliminate Boost dependency #352

Closed tap closed 9 years ago

tap commented 9 years ago

The crufty old Boost version needs to go.

When we tried this a couple of years ago we ran into crashes and problems, in part because Boost was maybe using Perl Regex instead of ECMA Regex or something like that? @theod may remember more details. Unfortunately, I don't think we have any unit tests for this code so it will likely be more painful to change than it needs to be...

Regardless, we still want to get rid of the unnecessary dependency on now-obsolete and non-standard code.

theod commented 9 years ago

I've added a test class for this. I'll try to change for std::reggae soon as possible

tap commented 9 years ago

That's great! Looking forward to using standard C++!

theod commented 9 years ago

I've commenting out the BOOST_REGEX defines in Foundation.yml. all test pass and nothing crash so I would say it's ok

theod commented 9 years ago

but I still don't have eliminate the boost stuff from the repo.

theod commented 9 years ago

but it seems that in TTPath.cpp there is still a use of boost that can't be removed.

jcelerier commented 9 years ago

grep "TTPath" **/*.{hpp,cpp} shows that TTPath is used nowhere except from TTPath.cpp, so I think it is safe to delete (and remove boost by the way - hurrah for build times!).

tap commented 9 years ago

Yes, TTPath was previously only used by the extension loader. Yay!

Tim

On Fri, Mar 27, 2015 at 9:40 AM, Jean-Michaël Celerier < notifications@github.com> wrote:

grep "TTPath" */.{hpp,cpp} shows that TTPath is used nowhere, so I think it is safe to delete (and remove boost by the way - hurrah for build times!).

— Reply to this email directly or view it on GitHub https://github.com/jamoma/JamomaCore/issues/352#issuecomment-86961654.

jcelerier commented 9 years ago

@nwolek : some tests shall still be run (for the regexes in JamomaForMax.cpp) but the tests in TTNodeLib.test.cpp for this are passing, so maybe this issue can be closed up too :)

nwolek commented 9 years ago

Closing. Thanks @jcelerier!