search

jamoma / JamomaMax

Implementation of Jamoma for Cycling'74 Max:
http://www.jamoma.org
41 stars 9 forks source link

Rename the class-wrapper .h and .cpp files for Graph and AudioGraph for name consistency #2

Open lossius opened 11 years ago

lossius commented 11 years ago

In sources/classwrapper there are currently 8 files:

MaxAudioGraph.cpp MaxAudioGraph.h MaxGraph.cpp MaxGraph.h MaxObjectTypes.h TTClassWrapperMax.cpp TTClassWrapperMax.h TTModularClassWrapperMax.cpp TTModularClassWrapperMax.h

This would be better if the following are renamed:

MaxAudioGraph.cpp => MaxAudioGraphWrapper.cpp MaxAudioGraph.h => MaxAudioGraphWrapper.h MaxGraph.cpp => MaxGraphWrapper.cpp MaxGraph.h => MaxGraphWrapper.h

Additionally it would be nice if the following two gets names that better explains what they are wrapping:

TTClassWrapperMax.cpp TTClassWrapperMax.h

Do you have any suggestions for what that might be, Tim?

tap commented 11 years ago

TTClassWrapperMax is generic, so it wraps currently Max and MSP objects. These files all have a tremendous amount of code duplication which is truly horrible. Not sure what to about all of that, but maybe they could all be combined into a single class wrapper?

Maybe @theod has an idea since he knows most about the Modular class wrapper.

theod commented 8 years ago

as it seems not very important for the release and as it will certainly cause trouble into the build I move this under 1.1/build milestone