jamoma / JamomaMax

Implementation of Jamoma for Cycling'74 Max:
http://www.jamoma.org
41 stars 9 forks source link

Cmake: when building for Max on the Mac, don't include the version nu… #993

Closed tap closed 8 years ago

tap commented 8 years ago

…mber in the binary/install_name. Additionally, now copy the binaries for the core into a common location that can be easily copied/linked. New "link.sh" script can be run to add sym links to this common location from the Jamoma Max package structure.

tap commented 8 years ago

Hmmm... I guess Travis is failing but it doesn't tell me why :-/

avilleret commented 8 years ago

according to https://travis-ci.org/jamoma/JamomaMax/builds/99350939#L240 it fails copying a dylib into the support folder, maybe we need to manually create this folder before copying

avilleret commented 8 years ago

hum, folder should be created with : https://github.com/jamoma/JamomaMax/blob/8da51f30874513ced9f26d44702832681fde198c/library/CMakeLists.txt#L170-L175 but it seems it is not. So I guess there might be an execution order issue.

tap commented 8 years ago

Hi @avilleret -- I think this is ready now if you are comfortable with it. It's little ugly, but I simply disabled the copy step when running on Travis.