search

jamoma / jamoma2

A header-only C++ library for building dynamic and reflexive systems with an emphasis on audio and media.
MIT License
30 stars 6 forks source link

merge nw/delay into master #57

Closed nwolek closed 8 years ago

nwolek commented 8 years ago

@tap - we now have a linear interpolating delay object. please review.

tap commented 8 years ago

Looks good -- definitely appreciate having the unit tests! Further work can be taken on from here via #56 and #60.

nwolek commented 8 years ago

Thanks @tap! With the merge, I believe this closes #28. Further work will continue on the issues you mention.

It is worth noting that the method implemented here will likely not work well once #59 is implemented. I realized this when I was reflecting on the work later. It is because it grabs a whole SampleBundles from the history instead of working sample by sample. It's more efficient but may causes issue with modulating parameters.

Good enough for now, but the topic will need discussion. And tests will let us know if something breaks along the way.

tap commented 8 years ago

Good point. There might be need for distinguishing between having a "static delay" vs a "modulated delay".