search

jamoma / jamoma2

A header-only C++ library for building dynamic and reflexive systems with an emphasis on audio and media.
MIT License
30 stars 6 forks source link

Eliminate steps in applySamplePadding() #86

Open nwolek opened 8 years ago

nwolek commented 8 years ago

Detailed discussion in pull #83

nwolek commented 8 years ago

Function can be found here: https://github.com/jamoma/jamoma2/blob/master/include/core/JamomaSample.h#L262

Lines 273-291 are the ones that we would like to improve / consolidate.

Test for this function can be found here: https://github.com/jamoma/jamoma2/blob/master/test/SampleBundle/SampleBundle.cpp#L215

tap commented 8 years ago

specifically, this comment:

We made a copy up above (see my previous comment). But we shouldn't need to copy here. We should be able to move instead. Might have to use std::move here. @nwolek , please feel free to make me a ticket to investigate this. Even if we have to copy up above, maybe we can cut our trouble down here somewhat?