search

jamoma / jamoma2

A header-only C++ library for building dynamic and reflexive systems with an emphasis on audio and media.
MIT License
30 stars 6 forks source link

Port position dataspace #96

Closed lossius closed 7 years ago

lossius commented 8 years ago

Hi @tap ,

I've now started implementing the position dataspace on the feature/96-position-dataspace branch. I've only added two units so far, but it's enough to reveal the stuff that we need to get ironed out before continuing.

This implies that:

Can you please take a look and see what needs to be done in order for this to compile? When done, please make a pull request for merging this back into the feature/dataspace branch (not master) and assign to me, and I'll keep working on it in order to implement the remaining units, as well as setting up unit tests.

Thanks!

tap commented 7 years ago

@lossius -- I don't see this branch. Is it pushed to Github?

tap commented 7 years ago

Hi @lossius -- please take a look at the above commit and tell me what you think...

lossius commented 7 years ago

Thanks, will check out tomorrow.

lossius commented 7 years ago

Thanks @tap this works. Brilliant! I'll see if I can finish of the dataspace by the end of the year then.

lossius commented 7 years ago

Closing this issue, one new issue showed up in the process, and is logged as #102 .

It remains to make an example of position dataspace conversions that illustrates how to vary the length of the returned vector based on what unit is used. The dataspace unit tests doesn't illustrate this.