search

jamoma / jamoma2

A header-only C++ library for building dynamic and reflexive systems with an emphasis on audio and media.
MIT License
30 stars 6 forks source link

The compare() method using in unit tests is not particularly useful #99

Closed lossius closed 8 years ago

lossius commented 8 years ago

Are we able to come up with a better way of comparing float32 and double than the compare() method? Below is a screenshot from one unit tests that fails because it seems unable to properly handle minor differences in values (due to numerical truncations and errors):

screen shot 2016-07-13 at 21 26 59

Also, when trying to step inside compare() it is impossible to see what's actually going on, as illustrated here:

screen shot 2016-07-13 at 21 31 05

Having seen Catch used elsewhere recently, I'm wondering if it would be a good idea to use Catch for Jamoma2 unit tests?

lossius commented 8 years ago

The conclusion of a skype session yesterday was to move to Catch. Initial work on this has started at the feature/dataspace branch.

Closing this issue, it will be replaced by more specific issues to port existing unit tests to Catch.