Fixes compilation issues for new versions of rubymotion.

jamonholmgren / ProMotion

ProMotion is a RubyMotion gem that makes iPhone development less like Objective-C and more like Ruby.

MIT License

1.26k stars 148 forks source link

Fixes compilation issues for new versions of rubymotion. #817

Closed markrickert closed 5 years ago

markrickert commented 5 years ago

$ motion --version
6.3

$ xcodebuild -version
Xcode 11.0
Build version 11A420a

I could believe it... i ran bundle && rake clean:all && rake spec and all the tests ran and passed! I'm pretty shocked right now... @jamonholmgren all those tests we wrote like 5 years ago and 6 ios version ago still work! ha!

andrewhavens commented 5 years ago

Looks like we need to update the Travis config, but your PR looks fine, so I'll merge it.

markrickert commented 5 years ago

I think we need to put a rubymotion license key in the travis config now... it's not free for CI anymore, as far as i understand.

cmckni3 commented 5 years ago

@markrickert Correct and the config should install RubyMotion using the installer. Newer Travis CI images do not include RubyMotion.

See https://github.com/amirrajan/rubymotion-applied/issues/126

andrewhavens commented 5 years ago

@cmckni3 @markrickert Sorry, I forgot to follow up on this one. Yes, I've been working on getting a new Travis build running on the latest versions of everything. I've been working with Amir to resolve the license key issue. Currently waiting for v6.4 release of RubyMotion before being able to know for sure if my configuration is correct. My work in progress is on the chore/travis-config branch.