search

jamovi / jmv

jamovi for R
https://www.jamovi.org
56 stars 27 forks source link

Translations #336

Closed victor-moreno closed 2 years ago

victor-moreno commented 2 years ago

Hi, I found a place in conttables.R where translation is needed but was not captured because the string is in a variable (self$options$compare), not literal. It is the row/column label of the footnote of the odds table, lines 531, 532

                    odds$addFootnote(rowNo=othRowNo, 'v[dp]', paste(self$options$compare, .('compared')))
                    odds$addFootnote(rowNo=othRowNo, 'v[rr]', paste(self$options$compare, .('compared')))

Probably the string can be captured for translation with something like

                    rows_or_columns <- ifelse (self$options$compare == "rows", "rows", "colums")
                    odds$addFootnote(rowNo=othRowNo, 'v[dp]', paste(rows_or_columns, .('compared')))
                    odds$addFootnote(rowNo=othRowNo, 'v[rr]', paste(rows_or_columns, .('compared')))