search

jamovi / jmv

jamovi for R
https://www.jamovi.org
59 stars 27 forks source link

Update: Tjur's R2 in Model Fit #375

Closed MAgojam closed 1 year ago

MAgojam commented 1 year ago

Jth, It might be interesting to have a look here for the suggestion to add Tjur's one to the 3 pseudo R2s already present. https://statisticalhorizons.com/r2logistic/ I personally agree with the last comment by E. Shtatland (2022/12/19).

raviselker commented 1 year ago

I still see a bunch of commented out code. Could you please remove this? And I'm not sure if you're familiar with squashing your commits (see for instance, https://www.git-tower.com/learn/git/faq/git-squash) but it would be great if you could squash all your commits into one commit.

jonathon-love commented 1 year ago

it would be great if you could squash all your commits into one commit.

i'd leave squashing to me when i merge ... its better if we see the changes to what's come before, and squashing discards all that.