search

jamovi / jmv

jamovi for R
https://www.jamovi.org
59 stars 27 forks source link

CI: Install jmvcore from github #391

Closed jonathon-love closed 1 year ago

jonathon-love commented 1 year ago

thanks so much sw!

i'm going to close this PR, because i opened it ... can i get you to open the same PR :P

by having you open the PR, its implied consent to us incorporating these changes into the project.

with thanks

shun2wang commented 1 year ago

@jonathon-love Yes I agree to merge these commits, I signed the CLA 2 years ago didn't I? hahaha, could you please reopen this PR or i don't mind you use these commit into PRs you opened. 😀

jonathon-love commented 1 year ago

haha, i know! :)

but can i get you to open the PR?

shun2wang commented 1 year ago

I don't have permission to open this PR but I can open new one for it.

jonathon-love commented 1 year ago

yeah, new one would be perfect. it should only be a couple of clicks.

with thanks