jampez77 / DVLA-Vehicle-Enquiry-Service

A custom component for connecting to the DVLAs Vehicle Enquiry Service API.
MIT License
22 stars 5 forks source link

adding multiple vehicles no unique sensors #5

Closed si458 closed 8 months ago

si458 commented 8 months ago

Hi Brilliant integration, just one nit pick, When u add multiple vehicles, the sensors aren't really being unique For example the mot due date is sensor.mot_expiry_date and sensor.mot_expiry_date_2 Where as the dvla calender entry is calendar.dvla_reg123 and calendar.dvla_reg1234 Can the sensor ids be changed to include the reg in front of the name?

jampez77 commented 8 months ago

Firstly, thanks for using the integration and thanks for taking the time to give a suggestion. I like that idea and have added it to the to do list.

madmic1314 commented 8 months ago

Brilliant integration - I second this change as well - we have 3 vehicles and it's difficult to keep track.

Some ideas on the sensor name could be sensor.reg.xxx or sensor.manufacturer.xxx ? The second might be difficult if people have two of the same model vehicles.

spiderlane commented 8 months ago

Yes this would be very useful. I really like the individual sensors (previously I used template sensors to split out the attributes) but ideally they need to be prefixed with the registration for use with more than one car.

rudgej commented 8 months ago

Hello. I did ask a separate question but no reply and I figured replying to this might ask a wider audience.

There are no setup instructions and nowhere to put the api key in the HACS integration.

Can anyone tell me where the key goes and how to call this service please ?

Thanks

si458 commented 8 months ago

@rudgej Once u added it in hacs, just install, it, restart ha, then fo into integrations then add the dvla, and put ur key/reg in there

rudgej commented 8 months ago

Thank you.

Working.

I will look in the morning but I assume I can call any registration from an automation tied to ANPR and get back the details of that vehicle not just the one added to the integration?

Many thanks Jeremy Sent from my iPhone

On 5 Jan 2024, at 07:46, Simon Smith @.***> wrote:



@rudgejhttps://github.com/rudgej Once u added it in hacs, just install, it, restart ha, then fo into integrations then add the dvla, and put ur key/reg in there

— Reply to this email directly, view it on GitHubhttps://github.com/jampez77/DVLA-Vehicle-Enquiry-Service/issues/5#issuecomment-1878259247, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARR5RRCIZRFRSXKN2Q7G6KTYM6VVVAVCNFSM6AAAAABBBP3N7SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZYGI2TSMRUG4. You are receiving this because you were mentioned.Message ID: @.***>

si458 commented 8 months ago

@rudgej NO the integration isnt designed for that! its designed to add say your own car(s) into HA to check dates of MOT, etc, and it creates devices with entities of them you cant call a function/automation/service to check a RANDOM car, (you would have to somehow add the integration every time you saw a reg, wait for it to setup/reply from entities then remove the integration! seems very hard work)

rudgej commented 8 months ago

Ok thanks. I will see what I can do to call the api directly.

What I want to do it run all cars that come up on my Anpr feed and put them into a Google docs spreadsheet . Will see how I get on.

si458 commented 8 months ago

Ok thanks. I will see what I can do to call the api directly.

What I want to do it run all cars that come up on my Anpr feed and put them into a Google docs spreadsheet . Will see how I get on.

Yeh that won't work, unless u maybe modified the integration to add a service, which u can then input the reg and call, which then passes that reg to dvla and returns data

rich-kettlewell commented 8 months ago

+1 on improving the sensor names.

my 2 cars have now created sensors called "sensor.colour" and "sensor_colour_2" .. far too generic :-)

si458 commented 8 months ago

fixed i think all, works perfectly on my setup, 2 missing lines will use

binary_sensor.dvla_REGHERELOWERCASE_DESCRIPTION
sensor.dvla_REGHERELOWERCASE_DESCRIPTION
calendar.dvla_REGHERELOWERCASE

image