search

jamsinclair / jSquash

Browser & Web Worker focussed image codec wasm bundles derived from the Squoosh App.
Apache License 2.0
250 stars 19 forks source link

build: rollback to emsdk@2 #68

Closed jahed closed 3 weeks ago

jahed commented 3 weeks ago

emsdk@3 does not build so use emsdk@2 for now. terser fails on import.meta syntax. NodeJS 18 (lowest LTS version) supports import.meta.url so that block isn't needed anyway.

netlify[bot] commented 3 weeks ago

Deploy Preview for luxury-jalebi-f8e0e8 canceled.

Name Link
Latest commit 88a89ae5f51915e0ffa82ba7f525fa6a0c824f9c
Latest deploy log https://app.netlify.com/sites/luxury-jalebi-f8e0e8/deploys/672004351abef60008089bcb
jamsinclair commented 3 weeks ago

I think the issue with emsdk v3 for mozjpeg should be solved by this commit https://github.com/jamsinclair/jSquash/commit/a6f8f59d9af14945e80ad2741c019e57628f0eca.

Let me know if it doesn't 🙇

jamsinclair commented 3 weeks ago

I've checked again. Cloudflare workers set import.meta.url to undefined. In order stop the Emscripten start-up logic from erroring we need to ensure this has a string value.

Thanks for the potential fix, but I'll close this for now as I think we've solved the mozjpeg compilation issues.