Short options names are improperly decoded

jamsix / ib-edavki

Skripta, ki prevede XML poročilo trgovalnih poslov v platformi InteractiveBrokers v XML format primeren za uvoz v obrazce Doh-KDVP, D-IFI, Doh-Div in Doh-Obr v eDavkih Finančne uprave.

MIT License

183 stars 59 forks source link

Short options names are improperly decoded #3

Closed pronebird closed 4 years ago

pronebird commented 4 years ago

I've noticed that long options are properly decoded, i.e:

MSFT 26JUL19 140.0 C

But short options are not, i.e displayed as such on e-davki:

AMD 1910

The detail view on e-davki displays the full name though:

AMD 1910 AMD 18OCT19 34.0 C

Is it intentional?

jamsix commented 4 years ago

Yeh @pronebird , that was a bug, fixed in https://github.com/jamsix/ib-edavki/commit/e91678edaabbd9f1b1d7886655b3b5ee278a88a9

Can you run it again on your data and verify?

pronebird commented 4 years ago

@jamsix nice, thanks!

I haven't imported the newly generated XML into E-davki as I've already submitted my reports, but I have verified the XML diff between old and new script's output.

The Code field is gone and I remember removing it manually on E-davki to avoid collisions as it seems that E-davki expects the codes to be unique.

<Name>XLF 30AUG19 25.0 P</Name>
- <Code>XLF   1908</Code>