Bugfix: security matching

jamsix / ib-edavki

Skripta, ki prevede XML poročilo trgovalnih poslov v platformi InteractiveBrokers v XML format primeren za uvoz v obrazce Doh-KDVP, D-IFI, Doh-Div in Doh-Obr v eDavkih Finančne uprave.

MIT License

183 stars 59 forks source link

Bugfix: security matching #54

Closed jamsix closed 2 years ago

jamsix commented 2 years ago

Security matching based on various unique identificators is now following the documented order of precedence: ISIN > CUSIP > securityID > CONID > Symbol

pronebird commented 2 years ago

Thanks a lot! I am gonna give it a go when I am back at my laptop later today.

pronebird commented 2 years ago

Everything seems to be alright at first glance. I'll match the numbers against my trade report over the week and let you know if I spot anything. Thanks again!

jamsix commented 2 years ago

Given we're entering the last week of the tax season, I'll merge this, fix later if needed.

pronebird commented 2 years ago

@jamsix makes sense. Based on the diff the only difference in the generated reports (before and after that PR) was that two conflicting assets (WEAT and CORN) were added to my tax report. Both contracts are trading at LSE and US exchanges under the same ticker.