Add FXCFD - Githubissues

jamsix / ib-edavki

Skripta, ki prevede XML poročilo trgovalnih poslov v platformi InteractiveBrokers v XML format primeren za uvoz v obrazce Doh-KDVP, D-IFI, Doh-Div in Doh-Obr v eDavkih Finančne uprave.

MIT License

173 stars 57 forks source link

Add FXCFD #83

Closed pronebird closed 1 year ago

pronebird commented 1 year ago

Add FXCFD type which is basically CFD on FX
Throw an error when script stumbles upon unknown asset type. Should help with pin pointing this kind of issues in the future.

jamsix commented 1 year ago

I think you need to replace these:

https://github.com/jamsix/ib-edavki/blob/233acbbcf6d96e058f6306e39f12a897aac2ad6d/ib_edavki.py#L909 https://github.com/jamsix/ib-edavki/blob/233acbbcf6d96e058f6306e39f12a897aac2ad6d/ib_edavki.py#L997

with:

elif trades[0]["assetCategory"] in ["CFD", "FXCFD"]:

pronebird commented 1 year ago

@jamsix Fixed.

jamsix commented 1 year ago

LGTM!