jamsocket / y-sweet

A realtime CRDT-based document store, backed by S3.
https://docs.jamsocket.com/y-sweet
Other
535 stars 29 forks source link

Implement YSweetConnection class in SDK #279

Closed paulgb closed 2 months ago

paulgb commented 2 months ago

This PR:

In the process, it modifies how authorization works in Y-Sweet so that a server token can be used to access any document.

Design doc: https://docs.google.com/document/d/10O4-i9sxUL5-bWjIYqgxbStJGqNCVLfP411J9x-fTFM/edit

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **y-sweet-debugger** | ⬜️ Ignored ([Inspect](https://vercel.com/drifting-corp/y-sweet-debugger/8Y3MaTSWiNTyAJoHCK3xhFCoP3TL)) | [Visit Preview](https://y-sweet-debugger-git-paul-dis-2681-impleme-16ed46-drifting-corp.vercel.app) | | Sep 17, 2024 7:42pm | | **y-sweet-demos** | ⬜️ Ignored ([Inspect](https://vercel.com/drifting-corp/y-sweet-demos/2ZDqWF6RSNLKttDH9buUaYXAMd7e)) | [Visit Preview](https://y-sweet-demos-git-paul-dis-2681-implement-18ff02-drifting-corp.vercel.app) | | Sep 17, 2024 7:42pm | | **y-sweet-gendocs** | ⬜️ Ignored ([Inspect](https://vercel.com/drifting-corp/y-sweet-gendocs/6KSyz2PhAh8y5M3wrvpfTLMAB53n)) | [Visit Preview](https://y-sweet-gendocs-git-paul-dis-2681-implemen-458125-drifting-corp.vercel.app) | | Sep 17, 2024 7:42pm |
paulgb commented 2 months ago

@greptileai

paulgb commented 2 months ago

Looks great! Nice job!

Two things:

  • I suppose this should get a major or minor version update? This is a breaking change as it requires the latest version of the y-sweet server, right? (Requires baseUrl on client token)
  • We'll need the same changes brought to the python SDK before Athena is good to go. Those will be in a follow up?